Re: [PATCH] gnu: sqlite: Enable DBSTAT_VTAB.

[Leo Famulari]

On Wed, Aug 31, 2016 at 01:34:30AM +0200, David Craven wrote:
> * gnu/packages/databases.scm (sqlite)[arguments]: Enable configure-flag
>   -DSQLITE_ENABLE_DBSTAT_VTAB.
> ---
>  gnu/packages/databases.scm | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index a04c375..ce51d28 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -520,10 +520,12 @@ for example from a shell script.")
>     (inputs `(("readline" ,readline)))
>     (arguments
>      `(#:configure-flags
> -      ;; Add -DSQLITE_SECURE_DELETE and -DSQLITE_ENABLE_UNLOCK_NOTIFY to
> -      ;; CFLAGS.  GNU Icecat will refuse to use the system SQLite unless 
> these
> -      ;; options are enabled.
> -      '("CFLAGS=-O2 -DSQLITE_SECURE_DELETE -DSQLITE_ENABLE_UNLOCK_NOTIFY")))
> +      ;; Add -DSQLITE_SECURE_DELETE, -DSQLITE_ENABLE_UNLOCK_NOTIFY and
> +      ;; -DSQLITE_ENABLE_DBSTAT_VTAB to CFLAGS.  GNU Icecat will refuse
> +      ;; to use the system SQLite unless these options are enabled.
> +      (list (string-append "CFLAGS=-O2 -DSQLITE_SECURE_DELETE "
> +                           "-DSQLITE_ENABLE_UNLOCK_NOTIFY "
> +                           "-DSQLITE_ENABLE_DBSTAT_VTAB"))))

When the new Icecat is released, I think we should graft this change
onto the master branch. This is because the new Icecat will fix a bunch
of security bugs.