Re: [PATCH] gnu: Add p7zip.

[Ricardo Wurmus]

Efraim Flashner <address@hidden> writes:

> On September 2, 2016 2:51:03 PM GMT+03:00, Ricardo Wurmus <address@hidden> 
> wrote:
>>
>>Efraim Flashner <address@hidden> writes:
>>
>>> On Thu, Sep 01, 2016 at 03:05:34PM -0400, Kei Kebreau wrote:
>>>> Ricardo Wurmus <address@hidden> writes:
>>>> 
>>>> > Kei Kebreau <address@hidden> writes:
>>>> >
>>>> >> Ricardo Wurmus <address@hidden> writes:
>>>> >>
>>>> >>> Kei Kebreau <address@hidden> writes:
>>>> >>>
>>>> >>>> Whoops, last patch was a bit messy and stacked on the previous
>>one. This
>>>> >>>> patch should be better!
>>>> >>>
>>>> >>> I just wanted to push a slightly modified version of this
>>(attached) but
>>>> >>> I cannot actually build the package.  The patch to remove unused
>>code
>>>> >>> does not apply due to different line endings.
>>>> >>>
>>>> >>> Could you please take a look at this again and make sure that
>>the patch
>>>> >>> to the sources applies?
>>>> >>>
>>>> >>> ~~ Ricardo
>>>> >>>
>>>> >> I just tried it on my machine, and everything applied and built
>>>> >> correctly from a clean Guix tree. I don't exactly know how to
>>proceed
>>>> >> From here. Perhaps a third party can try to build from the patch?
>>>> >
>>>> > The problem might be with the inline patch in the email.  Don’t
>>know.
>>>> >
>>>> > ~~ Ricardo
>>>> 
>>>> I'll try sending it again, for lack of a better plan. If all else
>>fails
>>>> I can post it on paste.lisp.org.
>>
>>> Hunk #1 FAILED at 139 (different line endings).
>>[...]
>>> Hunk #1 FAILED at 47 (different line endings).
>>
>>These are the exact same errors I got.  Maybe the line endings were
>>converted automatically when you saved the patch with your editor?
>>
>>~~ Ricardo
>
> I opened the mail with mutt, passed the patch to "cd workspace/guix; git am", 
> which is my normal workflow

Sorry, my reply was meant to be directed at Kei.

~~ Ricardo