Re: [PATCH 4/9] services: syslog: Use syslog-configuration.

[Ludovic Courtès]

David Craven <address@hidden> skribis:

> * gnu/services/base.scm (<syslog-configuration>): New variable.
> (syslog-service-type): Use <syslog-configuration>.
> (syslog-service): Use <syslog-configuration>.

Please mention the gnu/tests/base.scm changes here.

> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -73,15 +73,15 @@
>  
>              %nscd-default-caches
>              %nscd-default-configuration
> -
>              nscd-configuration
>              nscd-configuration?
> -
>              nscd-cache
>              nscd-cache?
> -

Please keep the spacing.

> +(define-record-type* <syslog-configuration>
> +  syslog-configuration  make-syslog-configuration
> +  syslog-configuration?
> +  (syslogd              syslog-configuration-syslogd
> +                        (default #~(string-append #$inetutils 
> "/libexec/syslogd")))
> +  (config-file          syslog-configuration-config-file
> +                        (default %default-syslog.conf)))

Good idea!

> -(define* (syslog-service #:key (config-file %default-syslog.conf))
> +(define* (syslog-service #:optional (config (syslog-configuration)))
>    "Return a service that runs @command{syslogd}.  If configuration file
>  name @var{config-file} is not specified, use some reasonable default
>  settings.
>  
>  @xref{syslogd invocation,,, inetutils, GNU Inetutils}, for more
>  information on the configuration file syntax."
> -  (service syslog-service-type config-file))
> +  (service syslog-service-type config))

Could you update the docstring and guix.texi, and add an @deftp for
‘syslog-configuration’ in guix.texi?

TIA!

Ludo’.