guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Feedback, ideas, discussion: tracking patches, discussions, bugs.


From: David Craven
Subject: Re: Feedback, ideas, discussion: tracking patches, discussions, bugs.
Date: Sat, 3 Sep 2016 21:53:07 +0200

> I was going to post a patch over several files removing redundant
> mkdir-p expressions,

> but decided against it! If you run something like  `ack '\(install-file'
> -B 7| ack  'mkdir-p' -A 7'

> You can see them, since install-file already contains a mkdir-p.

I think this is going a little off-topic.

> Also It seems like

> (let ((out  (assoc-ref outputs "out")))...) is set in almost every
> package definition,

> as if having some symbol for the outputs already might be more efficient??

If we start special-casing stuff, in no time we'll have a dozen
special cases. I think that that makes package definitions harder to
read. As it is currently there are a couple of primitives that do a
good job for defining packages without obfuscating stuff. I think
Ricardo already replied to this on IRC ;)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]