Re: [PATCH 2/3] guix: ant-build-system: add empty `tests` target to default build.xml.

[Hartmut Goebel]

Am 05.09.2016 um 22:26 schrieb Danny Milosavljevic:
> I see what you mean. But is it still possible to easily find out which 
> packages have tests and which haven't after your patch?

We are talking about the case when #:jar-name is specified. Only in this
case a build.xml will be generated.

Situation prior to this patch:

The generated build.xml does not include a "test" target. Phase "check"
will fail, since it wants to build the (non-existing) "test" target.
Solutions are a) set #:test? #f, b) remove phase "check" or c) define
your own "check" phase. If you want to run tests on the package, you
need to replace the "check" phase by something meaningful.

Situation avert the patch:

The generated build.xml include a "test" target. Phase "check" will
pass, since there is now a dummy "test" target. If you want to run tests
on the package, you need to replace the "check" phase by something
meaningful.


So the *behaviour* did not check. The only thing that has changes is the
need to either a) set #:test? #f, b) remove phase "check".

As of today, only four packages define a #:jar-name and all of these had
':tests? #f'.

> Also, would it be possible to auto-discover jUnit tests instead?

Maybe. But this is beyond my Java knowledge.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | address@hidden               |
| www.crazy-compilers.com | compilers which you thought are impossible |