Re: [PATCH 3/3] gnu: Add utox.

[Efraim Flashner]

On Wed, Sep 07, 2016 at 09:00:02PM -0400, Erik Edrosa wrote:
> * gnu/packages/messaging.scm (utox): New variable.
> ---
>  gnu/packages/messaging.scm | 44 +++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 43 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index b95239a..27086c8 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -64,7 +64,9 @@
>    #:use-module (gnu packages tls)
>    #:use-module (gnu packages icu4c)
>    #:use-module (gnu packages video)
> -  #:use-module (gnu packages xiph))
> +  #:use-module (gnu packages xiph)
> +  #:use-module (gnu packages audio)
> +  #:use-module (gnu packages fontutils))
>  
>  (define-public libotr
>    (package
> @@ -612,4 +614,44 @@ protocols.")
>        (license gpl3+)
>        (home-page "https://tox.chat";))))
>  
> +(define-public utox
> +  (package
> +   (name "utox")
> +   (version "0.9.8")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri (string-append "https://github.com/GrayHatter/uTox/archive/v";
> +                         version ".tar.gz"))

This one also needs a 'file-name' field, otherwise it'll save the source
as 'hash-v0.9.8.tar.gz' and we'll have no idea what it is.

> +     (sha256
> +      (base32
> +       "13hfqbwzcgvfbvf9yjm62aqsvxnpqppb50c88sys43m7022yqcsy"))))
> +   (build-system gnu-build-system)
> +   (arguments
> +    '(#:make-flags (list (string-append "PREFIX=" %output)
> +                         "CC=gcc")
> +      #:tests? #f
> +      #:phases (alist-delete 'configure %standard-phases)))

Same as the last one, why no tests? Also, 'modify-phases'

> +   (inputs
> +    `(("libtoxcore" ,libtoxcore)
> +      ("filteraudio" ,filteraudio)
> +      ("dbus" ,dbus)
> +      ("openal" ,openal)
> +      ("libvpx" ,libvpx)
> +      ("libsodium" ,libsodium)
> +      ("freetype" ,freetype)
> +      ("fontconfig" ,fontconfig)
> +      ("v4l-utils" ,v4l-utils)
> +      ("libx11" ,libx11)
> +      ("libxext" ,libxext)
> +      ("libxrender" ,libxrender)))

more of an aesthetic thing, can you make the inputs alphabetized?

> +   (native-inputs
> +    `(("pkg-config" ,pkg-config)))
> +   (synopsis "Lightweight Tox client")
> +   (description "The lightest and fluffiest Tox client.  Tox is a
> +distributed and secure instant messenger with audio and video chat
> +capabilities.")
> +   (home-page "http://utox.org/";)
> +   (license gpl3+)))

I believe it is just gpl3

> +
>  ;;; messaging.scm ends here
> -- 
> 2.10.0
> 

This one also looks really good. Can you send an updated patch?

-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature