Re: [PATCH] gnu: Add schismtracker.

[Kei Kebreau]

address@hidden (Ludovic Courtès) writes:

> Marius Bakke <address@hidden> skribis:
>
>> Kei Kebreau <address@hidden> writes:
>
> [...]
>
>>> +    (home-page "http://schismtracker.org";)
>>> +    (synopsis "Impulse Tracker clone")
>>
>> I think this should be more generic. The tagline from github works
>> pretty well: "Oldschool sample-based music composition tool".
>
> +1
>
>> The rest LGTM. But! The package records build time in version.c. I
>> managed to make it reproducible by adding a phase like this:
>>
>>           (add-before 'build 'make-reproducible
>>             (lambda _
>>               ;; Remove use of __DATE__ and __TIME__ for reproducibility.
>>               (substitute* "schism/version.c"
>>                 (("Schism Tracker built %s %s.*$")
>>                  (string-append "Schism Tracker version " ,version "\");")))
>>               #t))
>
> I would suggest making it a ‘snippet’ instead, as we usually do in
> such
> cases.
>
> Thanks Kei & Marius!
>
> Ludo’.

I think I got everything... Will this do?

*Forgot to cc the mailing list last time! :P

0001-gnu-Add-schismtracker.patch
Description: Text document

signature.asc
Description: PGP signature