[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/17] gnu: Add make-linux-libre-source.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 11/17] gnu: Add make-linux-libre-source. |
Date: |
Sun, 11 Sep 2016 23:21:01 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
David Craven <address@hidden> skribis:
> * gnu/packages/linux-libre.scm (make-linux-libre-source): New variable.
> (linux-libre, linux-libre-4.4, linux-libre-4.1): Use
> make-linux-libre-source.
> (linux-libre-urls): Remove.
[...]
> -(define (linux-libre-urls version)
> - "Return a list of URLs for Linux-Libre VERSION."
I would keep it…
> +(define-public (make-linux-libre-source version hash)
> + (origin
> + (method url-fetch)
> + (uri (list (string-append
> + "http://linux-libre.fsfla.org/pub/linux-libre/releases/"
> + version "-gnu/linux-libre-" version "-gnu.tar.xz")
> +
> + ;; XXX: Work around <http://bugs.gnu.org/14851>.
> + (string-append
> + "ftp://alpha.gnu.org/gnu/guix/mirror/linux-libre-"
> + version "-gnu.tar.xz")
> +
> + ;; Maybe this URL will become valid eventually.
> + (string-append
> + "mirror://gnu/linux-libre/" version "-gnu/linux-libre-"
> + version "-gnu.tar.xz")))
> + (sha256 (base32 hash))
> + (patches (origin-patches %boot-logo-patch))))
… and make it a macro instead (and drop ‘make-’):
(define-syntax-rule (linux-libre-source version hash)
(origin
;; …
(sha256 (base32 hash))))
Since it’s a macro, we’d still have the compile-time behavior of
‘base32’ that we discussed earlier.
WDYT?
Ludo’.
- Re: [PATCH 06/17] gnu: linux-libre: Add support for cross-compilation., (continued)
- [PATCH 08/17] gnu: make-linux-libre: Add additional-configuration parameter., David Craven, 2016/09/09
- Re: [PATCH 08/17] gnu: make-linux-libre: Add additional-configuration parameter., Ludovic Courtès, 2016/09/11
- [PATCH 09/17] gnu: dtc: Remove patch-paths phase., David Craven, 2016/09/09
- Re: [PATCH 09/17] gnu: dtc: Remove patch-paths phase., Ludovic Courtès, 2016/09/11
- [PATCH 10/17] gnu: Add u-boot-beagle-bone-black., David Craven, 2016/09/09
- Re: [PATCH 10/17] gnu: Add u-boot-beagle-bone-black., Ludovic Courtès, 2016/09/11
- [PATCH 11/17] gnu: Add make-linux-libre-source., David Craven, 2016/09/09
- Re: [PATCH 11/17] gnu: Add make-linux-libre-source.,
Ludovic Courtès <=
- Re: [PATCH 11/17] gnu: Add make-linux-libre-source., Ludovic Courtès, 2016/09/11
- [PATCH 13/17] gnu: make-linux-libre: Add zImage to output., David Craven, 2016/09/09
- Re: [PATCH 13/17] gnu: make-linux-libre: Add zImage to output., Ludovic Courtès, 2016/09/11
- Re: [PATCH 13/17] gnu: make-linux-libre: Add zImage to output., Danny Milosavljevic, 2016/09/12
- Re: [PATCH 13/17] gnu: make-linux-libre: Add zImage to output., David Craven, 2016/09/12
- [PATCH 12/17] gnu: make-linux-libre: Add extra-version parameter., David Craven, 2016/09/09
- Re: [PATCH 12/17] gnu: make-linux-libre: Add extra-version parameter., Ludovic Courtès, 2016/09/11
- [PATCH 17/17] gnu: Add linux-libre-beagle-bone-black., David Craven, 2016/09/09
- Re: [PATCH 17/17] gnu: Add linux-libre-beagle-bone-black., Ludovic Courtès, 2016/09/11
- [PATCH 15/17] gnu: make-linux-libre: Add supported-systems parameter., David Craven, 2016/09/09