guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] gnu: Add femtolisp.


From: ng0
Subject: Re: [PATCH 1/2] gnu: Add femtolisp.
Date: Wed, 14 Sep 2016 10:15:34 +0000

Ricardo Wurmus <address@hidden> writes:

> ng0 <address@hidden> writes:
>
>> ng0 <address@hidden> writes:
>>
>>> [ Unknown signature status ]
>>> Ricardo Wurmus <address@hidden> writes:
>>>
>>>> Hi,
>>>>
>>>>> I hope the appended patch still applies.
>>>>
>>>> could you please send a new, complete patch?
>>>>
>>>> You seem to have removed the “#t” from the “install” phase
>>>> accidentally.  The return value should be kept.
>>>>
>>>> ~~ Ricardo
>>
>> Sorry, I'm not sure if I had sent the updated patch or not. The change
>> is so small.
>
> I’m sorry for the confusion.  Looking at the subject of these emails I
> assumed that this patch was supposed to *add* a *new* package, not
> modify an existing one.  I didn’t know that an earlier version had
> already been pushed.

No problem.

> In this case we should probably split these changes up as they are not
> related to one another.  Alternatively, the summary line should be
> changed to apply to all of the changes in this patch.

Can you give me an example how the summary line should look like then?

> ~~ Ricardo
>
>

-- 
              ng0



reply via email to

[Prev in Thread] Current Thread [Next in Thread]