[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add mcelog.
From: |
Marius Bakke |
Subject: |
Re: [PATCH] gnu: Add mcelog. |
Date: |
Wed, 14 Sep 2016 20:32:10 +0100 |
Tobias Geerinckx-Rice <address@hidden> writes:
> Marius,
>
> On 14/09/16 17:19, Marius Bakke wrote:
>> Another thing, I think the snippet should be moved to a phase, as AFAIK
>> origin snippets should be reserved for removing unwanted files, or for
>> reproducibility.
>
> Not if we use your suggested snapshot tarball, which rightly lack a .git
> directory. There is no way for the build system to divine the version
> number at build time with ‘git describe’.
>
> Unpatched mcelog, manually built from ‘guix download’ed sources, would
> report its version as ‘unknown’. With this snippet, it just works.
Yes, I was mostly echoing Leos sentiment from this post:
https://lists.gnu.org/archive/html/guix-devel/2016-08/msg00937.html
I don't think reporting "unknown" as a version is a critical bug, but
don't have any strong opinions either way. It seems like the manual
could use some clarification on its use, though.
Cheers,
Marius
Re: [PATCH] gnu: Add mcelog., Ludovic Courtès, 2016/09/14