[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch 4/10] argon2: Install pkg-config file.
From: |
Lukas Gradl |
Subject: |
Re: [Patch 4/10] argon2: Install pkg-config file. |
Date: |
Sat, 17 Sep 2016 11:47:58 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Thank you for your review!
Danny Milosavljevic <address@hidden> writes:
>> + (snippet
>> + '(let ((p (open-file "argon2.pc" "a")))
> ... ^ why?
>
>> + (begin
>> + (display
>> + (string-append "prefix=/usr/local\n"
>> + "exec_prefix=${prefix}\n"
>> + "includedir=${prefix}/include\n"
>> + "libdir=${prefix}/lib\n\n"
>> + "Name: Argon2\n"
>> + "Description: "
>> + "The Argon2 password hashing algorithm\n"
>> + "Version: 1.0.0\n"
>> + "Cflags: -I${includedir}/\n"
>> + "Libs: -L${libdir} -largon2\n") p)
>> + (close-output-port p))))
>
> Ok but please try to upstream this as well.
OK, I will look into that.
>
>> + (zero? (system* "ln" "-s"
>> + (string-append out "/lib/libargon2.so")
>> + (string-append out "/lib/libargon2.so.0")))
>
> The result of this will be ignored. Did you mean "(and ...)"?
Oops! Yes, I will send an updated patch later today.
>
>> + (zero? (system* ; Fix compatability for libtool based builds.
>> + "ln" "-s"
>> + (string-append out "/lib/libargon2.so")
>> + (string-append out "/lib/libargon2.so.0.0.0")))))))))
>
> Doesn't this have a soversion other than 0? I mean it's OK, I'm just
> asking to be sure - because the pkg-config file lists 1.0.0 and the
> name of the pkg-config file contains no soversion at all.
I am actually not sure about this. I noticed that one of the packages
that depends on opendht (I think libring, but need to make sure) is
looking for 'libargon2.so.0.0.0'. I did not find a way to convince it
to use 'libargon2.so' other than creating this symlink. I am not sure
if this is a good/acceptable way to solve this, it is probably not the
intended way. I also could not find documentation on this issue and i
am not sure which part of the toolchain is responsible for making the
'.so.X.X.X' versions of a library.
Thank you!
Best,
Lukas
signature.asc
Description: PGP signature
- Re: [Patch 1/10] Add pjproject., (continued)
[Patch 2/10] Add dbus-c++., Lukas Gradl, 2016/09/12
[Patch 3/10] Add gsm., Lukas Gradl, 2016/09/12
[Patch 4/10] argon2: Install pkg-config file., Lukas Gradl, 2016/09/12
- Re: [Patch 4/10] argon2: Install pkg-config file., Danny Milosavljevic, 2016/09/15
- Re: [Patch 4/10] argon2: Install pkg-config file., Lukas Gradl, 2016/09/18
- Re: [Patch 4/10] argon2: Install pkg-config file., Danny Milosavljevic, 2016/09/19
- Re: [Patch 4/10] argon2: Install pkg-config file., Lukas Gradl, 2016/09/25
- Re: [Patch 4/10] argon2: Install pkg-config file., Danny Milosavljevic, 2016/09/25
- Re: [Patch 4/10] argon2: Install pkg-config file., Lukas Gradl, 2016/09/25
- Re: [Patch 4/10] argon2: Install pkg-config file., Ludovic Courtès, 2016/09/28
Re: [Patch 5/10] opendht: Propagate argon2., Lukas Gradl, 2016/09/12