Re: [PATCH 1/2] gnu: gnunet: Add inputs.

[ng0]

Ricardo Wurmus <address@hidden> writes:

> ng0 <address@hidden> writes:
>
>> * gnu/packages/gnunet.scm (gnunet)[inputs]: Add inputs
>> zlib, perl, jansson, ncurses, nss, gmp, bluez, glib, libogg.
>> (gnunet)[native-inputs]: Move python-2 from here ...
>> to (gnunet)[inputs].
>
> Have you checked that the resulting build artifacts retain references to
> all these new inputs?

With the assumption that currently our gnunet usage is limited because
we ship out 0.10.1 which is no longer compatible to HEAD but a release
will happen soon, I don't know if all of this is featured in the very
old version 0.10.1, but iirc there weren't many changes in dependencies,
so they should be used.
Could be that I need to pass some switches. I'll send an updated patch
later and document which dependency is needed for which part.

> Is adding “bluez” and “libogg” really needed?  They seem a little
> unusual for networking software.

It is not just networking software.
It's been to long since I found out all these dependencies, I just
decided to add them to guix master now. Bluez is for bluetooth support
of whatever feature (look it up in either documentation or the
Makefile), libogg is needed for audio playback I think. I could be wrong
about this one. You know, the longer you work on something the more you
find and without comments it all gets obscure. But I really think libogg
in addition to libopus is for something audio related.
If you think comments are needed because someone in the future could
decide to cut down the "bloat", I can comment all the dependencies with
which part of GNUnet needs them.

https://gnunet.org/bugs/view.php?id=4618 I could also add tex, but I
will add a variant of gnunet later which adds tex as a dependency.

> ~~ Ricardo
>
>

-- 
              ng0