Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.

[Ivan Vilata i Balaguer]

Leo Famulari (2016-09-19 17:39:37 -0400) wrote:

> On Mon, Sep 19, 2016 at 11:24:02AM +0200, Ivan Vilata i Balaguer wrote:
> > Thanks Leo and Brendan for your comments, I'm writing new versions
> > of the packages following your suggestions, unfortunately I found
> > out that ``quickswitch.py`` makes use of the Debian-specific
> > ``which`` tool, so I'm also working on including a small patch
> > (which I've also [reported][1] for completeness).  More things to
> > learn!`;)`
> 
> `which` is not a Debian tool, and we do sometimes have to add it as an
> input to packages. Our package name is 'which'. It might be enough to
> just add the 'which' package to quickswitch-for-i3's inputs (or
> native-inputs, if `which` is only used while building).
> 
> www.gnu.org/software/which/

Oh my, I missed the actual ``which`` package, sorry!  Anyway it's only
used to check that ``dmenu`` is there, and the function that does the
check is pretty broken anyway, causing other errors (see [my PR][1]).
However I found a [simpler PR][2] that fixes all the errors and also
does away with the dependency on ``which``, so I closed my PR and will
use the latter.

[1]: https://github.com/proxypoke/quickswitch-for-i3/pull/28
[2]: https://github.com/proxypoke/quickswitch-for-i3/pull/24

Leo Famulari (2016-09-19 17:42:18 -0400) wrote:

> On Mon, Sep 19, 2016 at 08:20:26PM +1000, Brendan Tildesley wrote:
> > I'm not a fan of "quickswitch-for-i3" and "python-i3-py". Perhaps a
> > better solution is to ensure "i3-py" in the description or synopsis
> > so that `guix package -s' finds it. As for quickswitch, isn't the
> > upstream name also simply "quickswitch-i3"?
> 
> Our packaging guidelines say that we should use the "project name chosen
> upstream" [0], which in this case appears to be quickswitch-for-i3 [1].

The PyPi package, the ``setup(name=...)`` argument in ``setup.py`` and
the content of the readme use ``quickswitch-i3`` as the project short
name, while the GitHub URL and readme title use "quickswitch for i3" as
a more descriptive name.  In this case I consider the former name to be
the "official" short name, also compatible with ``pip`` and others.  Is
there any other similar case already in Guix?

> And python-i3-py does follow our conventions for naming Python modules
> [2].
> 
> [0]
> https://www.gnu.org/software/guix/manual/html_node/Package-Naming.html
> 
> [1]
> https://github.com/proxypoke/quickswitch-for-i3
> 
> [2]
> https://www.gnu.org/software/guix/manual/html_node/Python-Modules.html

So I can do a third iteration with the PR#24 patch and package names
``python-i3-py`` and ``quickswitch-i3``.  What do you think?

One more time, thanks for your help and comments!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/