Re: [PATCH 42/42] gnu: Add darcs.

[ng0]

Leo Famulari <address@hidden> writes:

> On Sun, Sep 18, 2016 at 04:10:22PM +0000, ng0 wrote:
>> * gnu/packages/version-control.scm (darcs): New variable.
>
>> +;; Darcs has no https support: http://irclog.perlgeek.de/darcs/2016-09-17
>> +;; 
>> http://darcs.net/manual/Configuring_darcs.html#SECTION00440070000000000000
>> +;; and results of search engines will show that if the protocol is http, 
>> https
>> +;; is never mentioned.
>> +(define-public darcs
>> +  (package
>> +    (name "darcs")
>> +    (version "2.12.4")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append 
>> "https://hackage.haskell.org/package/darcs/";
>> +                                  "darcs-" version ".tar.gz"))
>> +              (sha256
>> +               (base32
>> +                "0jfwiwl5k8wspciq1kpmvh5yap4japrf97s9pvhcybxxhaj3ds28"))))
>> +    (build-system haskell-build-system)
>> +    (arguments
>> +     `(#:configure-flags '("-fpkgconfig" "-fcurl" "-flibiconv" "-fthreaded"
>> +                           "-fnetwork-uri" "-fhttp" "--flag=executable"
>> +                           "--flag=library")
>> +       #:tests? #f)) ; 20 failing shell tests out of over 400
>
> When the test suite fails, it provides a path to the log of the test
> suite. I built with --keep-failed to inspect the log, but the file does
> not exist.
>
> Since the test suite is not passing, and there is no log of the tests,
> it's hard to decide what to do :)

Strange. Can you add a comment for this in the package, so we can fix it
eventually?

> Does this darcs package work for your use case? Does anyone have advice?
>

Additionally: Should the complete commented inputs go? They are parts of
base of ghc, but then again they display what ghc needs.

So far I was able to "darcs get http://pijul.org";, I have not signed up
at a darcs hosting to push, I thought someone will report a bug when a
feature of darcs is broken. My use case worked.

For all the other packages: The changes are okay for me.

For @ version: The error message Guix throws should be extended. I am
doing "-" versions, but I've also seen "@" versions in the code and was
confused by the message guix gave me so I switched them to @.

Thanks for reviewing this huge bundle!
-- 
              ng0