Re: [PATCH 1/3] gnu: Add arm-none-eabi cross compiler.

[Ludovic Courtès]

Hi!

Ricardo Wurmus <address@hidden> skribis:

> * gnu/packages/bootstrap.scm (glibc-dynamic-linker): Add case for "arm-eabi".
> * gnu/packages/embedded.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

[...]

> +;; Commit hashes and SVN revisions for xbinutils and xgcc are taken
> +;; from https://launchpadlibrarian.net/209776344/release.txt
> +
> +(define-public xbinutils-arm-none-eabi

[...]

> +      (arguments
> +       `(,@(substitute-keyword-arguments (package-arguments parent)
> +             ((#:configure-flags flags)
> +              `(cons "--enable-multilib"
> +                     (delete "--disable-multilib" ,flags)))))))))

Why is multilib support needed?  Could you add a comment here?

Also, `,@lst is equivalent to lst.  :-)

> +       `(,@(substitute-keyword-arguments (package-arguments xgcc)
            ^^
Same here.

> +             ((#:configure-flags flags)
> +              `(append (list "--enable-multilib"
> +                             "--with-newlib"
> +                             "--with-multilib-list=armv6-m,armv7-m,armv7e-m"
> +                             "--with-host-libstdcxx=-static-libgcc 
> -Wl,-Bstatic,-lstdc++,-Bdynamic -lm"
> +                             "--enable-plugins"
> +                             "--disable-decimal-float"
> +                             "--disable-libffi"
> +                             "--disable-libgomp"
> +                             "--disable-libmudflap"
> +                             "--disable-libquadmath"
> +                             "--disable-libssp"
> +                             "--disable-libstdcxx-pch"
> +                             "--disable-nls"
> +                             "--disable-shared"
> +                             "--disable-threads"
> +                             "--disable-tls"
> +                             "--with-gnu-as"
> +                             "--with-gnu-ld")
> +                       (delete "--disable-multilib" ,flags)))))))))

Could you add comments explaining briefly where these flags come from?
Normally --with-gnu-* are not needed because ./configure should detect
that.

Thank you,
Ludo’.