Re: [PATCH 1/6] gnu: Add picocom.

[Leo Famulari]

On Mon, Sep 26, 2016 at 12:34:42PM +0200, David Craven wrote:
> * gnu/packages/terminals.scm (picocom): New variable.

> +    (arguments
> +     `(#:make-flags '("CC=gcc")
> +       #:tests? #f

Please add a comment saying that there is no test suite (that's what I
understand from skimming the GitHub web page).

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin"))
> +                    (man (string-append out "/share/man")))

This path should be "/share/man/man1".

Otherwise looks good to me!