Re: [PATCH 2/6] gnu: %default-extra-linux-options: Remove redundant options.

[Ludovic Courtès]

Hi David,

David Craven <address@hidden> skribis:

> * gnu/packages/linux.scm (%default-extra-linux-options): Remove
>   redundant options.

This patches appears to break things:

--8<---------------cut here---------------start------------->8---
$ sudo ./pre-inst-env guix system reconfigure 
~/src/configuration/pluto-configuration.scm --fallback

[...]

Backtrace:
In ice-9/boot-9.scm:
 157: 13 [catch #t #<catch-closure 8c9aa0> ...]
In unknown file:
   ?: 12 [apply-smob/1 #<catch-closure 8c9aa0>]
In ice-9/boot-9.scm:
  63: 11 [call-with-prompt prompt0 ...]
In ice-9/eval.scm:
 432: 10 [eval # #]
In ice-9/boot-9.scm:
2401: 9 [save-module-excursion #<procedure 8e7800 at ice-9/boot-9.scm:4045:3 
()>]
4050: 8 [#<procedure 8e7800 at ice-9/boot-9.scm:4045:3 ()>]
1724: 7 [%start-stack load-stack #<procedure 8faae0 at ice-9/boot-9.scm:4041:10 
()>]
1729: 6 [#<procedure 8fd9c0 ()>]
In unknown file:
   ?: 5 [primitive-load 
"/gnu/store/8lmcdhipd7ccjpaqd3a8pbb2yvn9d7v0-linux-modules-builder"]
In ice-9/eval.scm:
 432: 4 [eval # ()]
 453: 3 [eval # ()]
 411: 2 [eval # ()]
In srfi/srfi-1.scm:
 578: 1 [map #<procedure lookup (a)> ("ahci" "usb-storage" "uas" ...)]
In unknown file:
   ?: 0 [scm-error misc-error #f ...]

ERROR: In procedure scm-error:
ERROR: module not found "virtio_pci.ko" 
"/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/modules"
builder for `/gnu/store/x0jqyr639karxakl0q2807ka608g4k3n-linux-modules.drv' 
failed with exit code 1
--8<---------------cut here---------------end--------------->8---

“make check-system TESTS=basic” fails similarly.

Indeed, most of the virtio modules disappeared:

--8<---------------cut here---------------start------------->8---
$ find 
"/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/modules" 
-name virtio\*
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/modules/4.7.5-gnu/kernel/drivers/char/hw_random/virtio-rng.ko
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/modules/4.7.5-gnu/kernel/drivers/scsi/virtio_scsi.ko
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/modules/4.7.5-gnu/kernel/drivers/gpu/drm/virtio
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/modules/4.7.5-gnu/kernel/drivers/gpu/drm/virtio/virtio-gpu.ko
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/modules/4.7.5-gnu/kernel/drivers/virtio
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/modules/4.7.5-gnu/kernel/drivers/virtio/virtio_input.ko
--8<---------------cut here---------------end--------------->8---

I think we need to revert this patch.  Could you please look at it?

TIA!

Ludo’.