Re: [PATCH v3 0/6] Add FPGA Tools

[Theodoros Foradis]

Danny Milosavljevic writes:

> This patch adds FPGA tools.
>
> Danny Milosavljevic (6):
>   gnu: Add abc.
>   gnu: Add iverilog.
>   gnu: Add yosys.
>   gnu: Add icestorm.
>   gnu: Add arachne-pnr.
>   gnu: Add gtkwave.
>
>  gnu/local.mk          |   1 +
>  gnu/packages/fpga.scm | 311 
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 312 insertions(+)
>  create mode 100644 gnu/packages/fpga.scm

I tested the patches again, and they are working correctly after the fix in
libftdi. Should we still delete "-I/usr/local/include" from the makefile
of icestorm to ensure it doesn't build wrongly in non-guixsd systems or is
it unnecessary?

Gtkwave is fine as well. Maybe we would like to add it in
another file though (e.g. engineering.scm), in case it's used  with
other packages in the future.

Regards,
-- 
Theodoros Foradis