>From c61c799da21f349c739f9d094d348ae429a91ffc Mon Sep 17 00:00:00 2001 From: Ben Woodcroft Date: Sat, 24 Sep 2016 22:44:55 +1000 Subject: [PATCH 1/2] gnu: perl: Use configure-flags. * gnu/packages/perl.scm (perl)[arguments]: Use configure-flags. --- gnu/packages/perl.scm | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index f0c4e36..aea05dd 100644 --- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -60,6 +60,19 @@ (build-system gnu-build-system) (arguments '(#:tests? #f + #:configure-flags + (let ((out (assoc-ref %outputs "out")) + (libc (assoc-ref %build-inputs "libc"))) + (list + (string-append "-Dprefix=" out) + (string-append "-Dman1dir=" out "/share/man/man1") + (string-append "-Dman3dir=" out "/share/man/man3") + "-de" "-Dcc=gcc" + "-Uinstallusrbinperl" + "-Dinstallstyle=lib/perl5" + "-Duseshrplib" + (string-append "-Dlocincpth=" libc "/include") + (string-append "-Dloclibpth=" libc "/lib"))) #:phases (modify-phases %standard-phases (add-before 'configure 'setup-configure @@ -77,21 +90,9 @@ #t)) (replace 'configure - (lambda* (#:key inputs outputs #:allow-other-keys) - (let ((out (assoc-ref outputs "out")) - (libc (assoc-ref inputs "libc"))) - (zero? - (system* "./Configure" - (string-append "-Dprefix=" out) - (string-append "-Dman1dir=" out "/share/man/man1") - (string-append "-Dman3dir=" out "/share/man/man3") - "-de" "-Dcc=gcc" - "-Uinstallusrbinperl" - "-Dinstallstyle=lib/perl5" - "-Duseshrplib" - (string-append "-Dlocincpth=" libc "/include") - (string-append "-Dloclibpth=" libc "/lib")))))) - + (lambda* (#:key configure-flags #:allow-other-keys) + (zero? (apply system* (append (list "./Configure") + configure-flags))))) (add-before 'strip 'make-shared-objects-writable (lambda* (#:key outputs #:allow-other-keys) -- 2.10.0 >From d382e48d801406897c27b045ab1feb20cfec6db4 Mon Sep 17 00:00:00 2001 From: Ben Woodcroft Date: Sat, 24 Sep 2016 23:22:54 +1000 Subject: [PATCH 2/2] gnu: perl: Enable threading support. * gnu/packages/perl.scm (perl)[arguments]: Configure with '-Dusethreads'. * gnu/packages/commencement.scm (perl-boot0)[arguments]: Omit inherited '-Dusethreads' flag during configure. --- gnu/packages/commencement.scm | 32 ++++++++++++++++++++------------ gnu/packages/perl.scm | 3 ++- 2 files changed, 22 insertions(+), 13 deletions(-) diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index 8f1ecf8..61df290 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -275,18 +275,26 @@ (replacement #f) (arguments ;; At the very least, this must not depend on GCC & co. - (let ((args `(#:disallowed-references - ,(list %bootstrap-binutils)))) - (substitute-keyword-arguments (package-arguments perl) - ((#:phases phases) - `(modify-phases ,phases - ;; Pthread support is missing in the bootstrap compiler - ;; (broken spec file), so disable it. - (add-before 'configure 'disable-pthreads - (lambda _ - (substitute* "Configure" - (("^libswanted=(.*)pthread" _ before) - (string-append "libswanted=" before))))))))))))) + (let + ((args `(#:disallowed-references + ,(list %bootstrap-binutils))) + (sub1 + (substitute-keyword-arguments (package-arguments perl) + ((#:phases phases) + `(modify-phases ,phases + ;; Pthread support is missing in the bootstrap + ;; compiler (broken spec file), so disable it. + (add-before 'configure 'disable-pthreads + (lambda _ + (substitute* "Configure" + (("^libswanted=(.*)pthread" _ before) + (string-append "libswanted=" + before)))))))))) + (substitute-keyword-arguments sub1 + ;; Do not configure with -Dusethreads since pthread + ;; support is missing. + ((#:configure-flags configure-flags) + `(delete "-Dusethreads" ,configure-flags)))))))) (package-with-bootstrap-guile (package-with-explicit-inputs perl %boot0-inputs diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index aea05dd..4e1e7e1 100644 --- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -72,7 +72,8 @@ "-Dinstallstyle=lib/perl5" "-Duseshrplib" (string-append "-Dlocincpth=" libc "/include") - (string-append "-Dloclibpth=" libc "/lib"))) + (string-append "-Dloclibpth=" libc "/lib") + "-Dusethreads")) #:phases (modify-phases %standard-phases (add-before 'configure 'setup-configure -- 2.10.0