Re: [PATCH 00/14] Change python-build-system (fixes bug 20765)

[Ludovic Courtès]

Hi!

Marius Bakke <address@hidden> skribis:

> Hartmut Goebel <address@hidden> writes:
>
>> Am 28.09.2016 um 17:54 schrieb Marius Bakke:
>>> Or push a branch somewhere?
>>
>> Branch is now available at 
>> <https://gitlab.com/htgoebel/guix/tree/python-build-system>
>
> Thanks a lot for doing this!
>
> After adding a couple of patches I'm able to build many python packages.
> Patch #2 mostly emulates NixOS "shim" setup.py[0], required for packages
> using distutils instead of setuptools.
>
> Some packages really don't like the new configure flags however (scons).
> Perhaps we should have them as default, but if #:configure-flags is set,
> let them be overridden?

In general it seems like a good pattern.

> Also some packages are missing a dependency on "python-py"[1].
>
> Perhaps we can set up a Hydra channel to deal with the fallout?

I haven’t really followed, but if the two of you agree on that, that’s
definitely something we can do!

> From a12000dd320cebeb920a4f790fe9206a2b6bda41 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <address@hidden>
> Date: Thu, 29 Sep 2016 18:29:21 +0100
> Subject: [PATCH 1/2] guix: python-build-system: fix configure flag append
>  (followup to dba07a8d1)
>
> ---
>  guix/build/python-build-system.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Seems reasonable (with proper commit log).

> From 84fa3e8be3d3d868ddb9278a96807086415b754d Mon Sep 17 00:00:00 2001
> From: Marius Bakke <address@hidden>
> Date: Thu, 29 Sep 2016 18:41:35 +0100
> Subject: [PATCH 2/2] guix: python-build-system: Import setuptools before
>  calling `setup.py'.
>
> This is needed for packages using "distutils" instead of "setuptools"
> since the former does not understand the
> "--single-version-externally-managed" flag. Also export __file__ since
> it will be unset when setup.py is called from python "exec".

Please move this explanation as a comment right above the newly-added
code.

> * guix/build/python-build-system.scm (call-setuppy): extend
> "python setup.py" call to import setuptools, export __file__, and
> call setup.py from setuptools python environment.

It might be worth adding a comment on the general context in the code
here.

Regardless, it’s a good idea to get feedback from Hartmut and whoever
else knows more about Python than myself before committing.  :-)

Speaking of which, could you create an account on savannah.gnu.org and
send your account name to the folks marked as “project admins” on
<https://savannah.gnu.org/projects/guix/>?  Please send it as an
OpenPGP-signed message, using the OpenPGP key that you will then use to
sign commits.  Also, make sure to upload said key to pgp.mit.edu and to
add it on Savannah too.  If anything is unclear, let me know.  :-)

TIA!

Ludo’.