Re: [PATCH 1/2] gnu: Add gsound.

[Ludovic Courtès]

Hello,

rennes <address@hidden> skribis:

> From 1d8368a12295c223626a3638d45e50a2043b980c Mon Sep 17 00:00:00 2001
> From: Rene Saavedra <address@hidden>
> Date: Sat, 1 Oct 2016 07:17:34 -0500
> Subject: [PATCH 1/2] gnu: Add gsound.
>
>       * gnu/packages/gsound.scm (gsound): New variable.
  ^^^^^^

Extra space here.  :-)

I think this should go to libcanberra.scm rather than its own module.
WDYT?

> +    (description
> +     "Designed to be used via GObject Introspection,
> +and is a thin wrapper around the libcanberra C library.")

Could you improve this description, as per
<https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>?

> +    (license license:lgpl2.1)))

It should be ‘lgpl2.1+’ (meaning “or any later version”), unless the “or
any later version” wording has been explicitly removed from the
copyright headers or the license file says so (unlikely in this case).

Could you send an updated patch?

Thanks!

Ludo’.