Re: [PATCH 10/12] gnu: Add slynk.

[Ludovic Courtès]

Andy Patterson <address@hidden> skribis:

> * gnu/packages/lisp.scm (slynk, slynk-sbcl, slynk-ecl): New variables.

[...]

> +    (synopsis "Common Lisp IDE for Emacs")
> +    (description "SLY is a fork of SLIME.  It also featrues a completely

To make it more standalone, maybe something like: “SLY is a fork of
SLIME, the foobar IDEish mode for Emacs.”

Typo: “features”.

> +redesigned REPL based on Emacs's own full-featured comint.el, live code

@file{comint.el}

> +(define slynk-sbcl-boot0
> +  (package
> +    (inherit slynk)
> +    (name "slynk-sbcl")

It’s best to include “-boot0” in ‘name’ too.

However, could you add a comment as to what this “boot” package does,
and what the general idea is?

> +(define slynk-mrepl-sbcl
> +  (package
> +    (inherit slynk-arglists-sbcl)
> +    (name "slynk-mrepl-sbcl")))
> +
> +(define slynk-mrepl-ecl
> +  (package
> +    (inherit slynk-arglists-ecl)
> +    (name "slynk-mrepl-ecl")))
> +
> +(define slynk-trace-dialog-sbcl
> +  (package
> +    (inherit slynk-arglists-sbcl)
> +    (name "slynk-trace-dialog-sbcl")))
> +
> +(define slynk-trace-dialog-ecl
> +  (package
> +    (inherit slynk-arglists-ecl)
> +    (name "slynk-trace-dialog-ecl")))
> +
> +(define slynk-profiler-sbcl
> +  (package
> +    (inherit slynk-arglists-sbcl)
> +    (name "slynk-profiler-sbcl")))

I don’t follow what’s going on here.  These are all the same packages as
“arglists” but with a different name?  What for?

> +                   (patch-asd-file
> +                    asd-file
> +                    (map
> +                     (lambda (dependency)
> +                       `(,dependency
> +                         . ,(string-append
> +                             (assoc-ref inputs dependency))))

Simply: (cons dependency (assoc-ref …)), more readable than the dot
notation here.

Thanks,
Ludo’.