[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: mail: Add notifymuch.
From: |
Leo Famulari |
Subject: |
Re: [PATCH] gnu: mail: Add notifymuch. |
Date: |
Sun, 9 Oct 2016 18:08:38 -0400 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Sun, Oct 09, 2016 at 10:33:18PM +0100, Christopher Baines wrote:
> * gnu/packages/mail.scm (notifymuch): New variable.
Thanks for this patch!
> + (version "0.1")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/kspi/notifymuch.git")
> + (commit "9d4aaf54599282ce80643b38195ff501120807f0")))
There are no "real" releases, right? I didn't see a 0.1 version on the
home-page.
If so, can you revise this patch to use the versioning method described
in the manual, section 7.6.3 Version Numbers [0]?
So, the resulting version string would be 0.0.0-1.9d4aaf5.
There is a recent example in 4b51b21ccf (gnu: Add cl-clx.).
By the way, for anyone reading along, the commit chosen by Christopher
is the current HEAD of the master branch.
> + (add-after 'install 'wrap-binary
> + (lambda* (#:key inputs outputs #:allow-other-keys)
I think 'inputs' can be removed since it isn't used here.
Looks good with these changes!
[0]
https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html