[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/12]: Add asdf-build-system.
From: |
Andy Patterson |
Subject: |
Re: [PATCH 0/12]: Add asdf-build-system. |
Date: |
Mon, 10 Oct 2016 15:24:30 -0230 |
Hi.
On Sat, 08 Oct 2016 21:28:46 +0800
address@hidden (宋文武) wrote:
> address@hidden (Ludovic Courtès) writes:
>
> > I browsed the patch series quickly; the packages I did not comment
> > on LGTM, modulo the question of whether we should prefix them.
> >
>
> Thanks for the review! I push them :-)
>
> (the V2 patches already use prefix names.)
Thanks, and especially for the review and suggestions.
Could you also take a look at the fix for ecl which I posted at
<https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00330.html>?
Without it, the ecl packages are a bit broken, for example:
$ guix environment --container --ad-hoc ecl ecl-slynk -- ecl -eval \
"(mapc 'require '(asdf slynk))"
which should give you a REPL with slynk loaded, but instead fails. As I
said, I'll try to get it fixed upstream for their next release.
Thanks,
--
Andy