Re: [PATCH 1/2] gnu: Add emacs-goto-chg.

[ng0]

Hi,

thanks for the review.

Alex Kost <address@hidden> writes:

> ng0 (2016-10-12 23:00 +0000) wrote:
>
>> * gnu/packages/emacs.scm (emacs-goto-chg): New variable.
>> ---
>>  gnu/packages/emacs.scm | 26 +++++++++++++++++++++++++-
>>  1 file changed, 25 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 1b345db..f04b71d 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -12,7 +12,7 @@
>>  ;;; Copyright © 2016 David Thompson <address@hidden>
>>  ;;; Copyright © 2016 Matthew Jordan <address@hidden>
>>  ;;; Copyright © 2016 Roel Janssen <address@hidden>
>> -;;; Copyright © 2016 ng0 <address@hidden>
>> +;;; Copyright © 2016 ng0 <address@hidden>
>>  ;;; Copyright © 2016 Alex Griffin <address@hidden>
>>  ;;; Copyright © 2016 Nicolas Goaziou <address@hidden>
>>  ;;; Copyright © 2016 Alex Vong <address@hidden>
>> @@ -2981,6 +2981,30 @@ Lua programing language}.")
>>  news items, openrc and runscripts.")
>>      (license license:gpl2+)))
>>  
>> +(define-public emacs-goto-chg
>> +  (package
>> +    (name "emacs-goto-chg")
>> +    (version "20131228.659")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "http://melpa.org/packages/goto-chg-";
>> +             version ".el"))
>
> Although the source of this package is the emacswiki, I used it here as
> well, also I changed the version to "1.6" (according to source).

Oh.. thanks!

>> +       (sha256
>> +        (base32
>> +         "1763qs6xprbb86bsxs4sh35rdcnb3v1zam4pc2akkd4wimg83k2l"))))
>> +    (build-system emacs-build-system)
>> +    ;; This is correct, the source/www is a wiki.
>> +    (home-page "http://www.emacswiki.org/emacs/goto-chg.el";)
>> +    (synopsis "Go to last change")
>> +    (description
>> +     "Goto-Chg goes to the point of the most recent edit in the
>> +buffer.  When repeated, go to the second most recent edit, etc.
>> +Negative argument, C-u -, for reverse direction.  Works by
>> +looking into buffer-undo-list to find points of edit.")
>
> I rephrased the description a bit to mention 'goto-last-change' command.
>
>> +    (license license:gpl3+)))
>
> This is actually gpl2+

Don't rely on what other services/sites point out I'd say. Thanks for
correction.

>> +
>>  (define-public emacs-writegood-mode
>>    (package
>>      (name "emacs-writegood-mode")
>
> Applied as ce74e520115a6d51b237a953fdf1468bc2b54d44, thanks!
>
> -- 
> Alex
>

-- 
♥Ⓐ  ng0