Re: [PATCH] gnu: Add python-whoosh.

[Marius Bakke]

Kei Kebreau <address@hidden> writes:

> Ricardo Wurmus <address@hidden> writes:
>
>> * gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.
>> ---
>>  gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index 6207896..69c7d36 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -8823,6 +8823,36 @@ library.")
>>        (native-inputs `(("python2-setuptools" ,python2-setuptools)
>>                         ,@(package-native-inputs responses))))))
>>  
>> +(define-public python-whoosh
>> +  (package
>> +    (name "python-whoosh")
>> +    (version "2.7.4")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "Whoosh" version))
>> +       (sha256
>> +        (base32
>> +         "10qsqdjpbc85fykc1vgcs8xwbgn4l2l52c8d83xf1q59pwyn79bw"))))
>> +    (build-system python-build-system)
>> +    (native-inputs
>> +     `(("python-setuptools" ,python-setuptools)
>> +       ("python-pytest" ,python-pytest)))
>> +    (home-page "http://bitbucket.org/mchaput/whoosh";)
>> +    (synopsis "Full text indexing, search, and spell checking library")
>> +    (description
>> +     "Whoosh is a fast, pure-Python full text indexing, search, and spell
>> +checking library.")
>> +    (license license:bsd-2)))
>> +
>> +(define-public python2-whoosh
>> +  (let ((whoosh (package-with-python2 (strip-python2-variant 
>> python-whoosh))))
>> +    (package (inherit whoosh)
>> +      (propagated-inputs
>> +       `(("python2-backport-ssl-match-hostname"
>> +          ,python2-backport-ssl-match-hostname)
>> +          ,@(package-propagated-inputs whoosh))))))
>> +
>>  (define-public python-pathlib
>>    (package
>>      (name "python-pathlib")
>
> Linting works fine, but outputs differ on each build. Is this a common
> problem with python packages?

Yes, it's a common problem with python packages. This should be largely
fixed by the new python build system however.

Wrt the patch, setuptools is not required for the python3 variant. But
since it will no longer be required for python2 either after the new
build system, I think it's okay to keep it for now, since it would
complicate the patch a lot.

LGTM.