guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/15] gnu: chez-scheme: Add search-path and fix i686 build.


From: Ludovic Courtès
Subject: Re: [PATCH 01/15] gnu: chez-scheme: Add search-path and fix i686 build.
Date: Mon, 17 Oct 2016 15:34:08 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Hello Federico,

Federico Beffa <address@hidden> skribis:

> On Sun, Oct 16, 2016 at 8:25 PM, Ricardo Wurmus <address@hidden> wrote:

[...]

>> Could you separate these different changes into different patches,
>> please?
>
> I've split them.

Thanks for taking the time.

> From c25b941dc4a0b5d04a871edb590a728b6075b081 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <address@hidden>
> Date: Mon, 17 Oct 2016 08:52:48 +0200
> Subject: [PATCH 01/17] gnu: chez-scheme: Add search-path.
>
> * gnu/packages/scheme.scm (chez-scheme): Do it.

Rather: … (chez-scheme)[native-search-paths]: New field.

Otherwise OK!

> From 7875840eb0f0d0d844da40735faabd10b791f0dd Mon Sep 17 00:00:00 2001
> From: Federico Beffa <address@hidden>
> Date: Mon, 17 Oct 2016 09:01:11 +0200
> Subject: [PATCH 02/17] gnu: chez-scheme: Fix i686 build.
>
> * gnu/packages/scheme.scm (chez-scheme): Add 'configure-flags', generalize
>   'configure' phase and simplify 'install-doc' phase.

These two parts are still logically unrelated; it’s best if you can
split, but OK for this time.

LGTM.

> From 0f2766f86058762443645583b491fb9097a510a3 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <address@hidden>
> Date: Mon, 17 Oct 2016 09:05:39 +0200
> Subject: [PATCH 03/17] gnu: chez-scheme: Move to new module.
>
> * gnu/packages/scheme.scm (chez-scheme, nanopass, stex): Move variables ...
> * gnu/packages/chez.scm (chez-scheme, nanopass, stex): ... here. New module.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add new file.

OK!

Thank you!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]