guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: bash-minimal: Assume getcwd works correctly when cross-


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: bash-minimal: Assume getcwd works correctly when cross-compiling
Date: Wed, 19 Oct 2016 21:54:57 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

address@hidden (Ludovic Courtès) skribis:

> address@hidden (Carlos Sánchez de La Lama) skribis:
>
>> * gnu/packages/bash.scm (bash-minimal): Assume getcwd works correctly
>> when cross compiling.
>> ---
>>  gnu/packages/bash.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
>> index f3d8517..b07367c 100644
>> --- a/gnu/packages/bash.scm
>> +++ b/gnu/packages/bash.scm
>> @@ -247,7 +247,8 @@ without modification.")
>>                   "--disable-nls"
>>  
>>                   ,@(if (%current-target-system)
>> -                       '("bash_cv_job_control_missing=no")
>> +                       '("bash_cv_job_control_missing=no"
>> +                     "bash_cv_getcwd_malloc=yes")
>
> No tabs please.  Otherwise LGTM, thanks!

I spoke too fast.  On master (Bash 4.3), this is unnecessary AFAICS:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build bash-minimal --target=mips64el-linux-gnu 
--no-grafts --no-build-hook
/gnu/store/1v6l54xzmzb19hdg5bizvzfz995lh1cp-bash-minimal-4.3.42-doc
/gnu/store/gawbc9mj2i37ycym06rbybi1k4kn8zfq-bash-minimal-4.3.42-include
/gnu/store/vic4zf9gpdzrcvj8kimb9cs3049ld60d-bash-minimal-4.3.42
$ git describe
v0.11.0-1743-gfe9bdb5
--8<---------------cut here---------------end--------------->8---

Is this addressing a problem you had with Bash 4.4 (on core-updates)?

TIA,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]