guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] gnu: Add python2-wxpython.


From: Theodoros Foradis
Subject: Re: [PATCH v2 3/3] gnu: Add python2-wxpython.
Date: Tue, 25 Oct 2016 20:13:55 +0300
User-agent: mu4e 0.9.17; emacs 25.1.1

Leo Famulari writes:

> On Tue, Oct 25, 2016 at 07:09:07PM +0300, Theodoros Foradis wrote:
>> * gnu/packages/wxwidgets.scm (python2-wxpython): New variable.
>
>> +       #:tests? #f ; tests fail
>

I'll try to give this one a second look.

> We should try to fix this, or at least understand why they are failing.
>
>> +    (native-inputs
>> +     `(("gtk+" ,gtk+-2)
>> +       ("expat" ,expat)
>> +       ("libjpeg" ,libjpeg)
>> +       ("libpng" ,libpng)
>> +       ("libtiff" ,libtiff)
>> +       ("libsm" ,libsm)
>> +       ("libx11" ,libx11)
>> +       ("mesa" ,mesa)
>> +       ("pkg-config" ,pkg-config)
>> +       ("python2-setuptools" ,python2-setuptools)
>> +       ("zlib" ,zlib)))
>
> To clarify, all these native-inputs are only used while building?
> Native inputs typically are not intended to be available once the
> package has been built and installed.

To quote Danny Milosavljevic, whose original patch of python2-wxpython I
modified:
> I added gtk, opengl etc as native inputs instead of regular inputs because 
> from the point of view of Python they are not direct inputs.

I guess this applies to gtk+,opengl,mesa and expat(?) (the others are
intented to be native-inputs for sure). I am unsure if they are intended
to be available at runtime. I assumed they were not, based on the
previous comment. If they, they should be moved to inputs.

How could I figure that out?
-- 
Theodoros Foradis



reply via email to

[Prev in Thread] Current Thread [Next in Thread]