Re: [PATCH 3/3] gnu: Add openocd.

[David Craven]

Hi Theodoros,

Do we really need this patch? Is there a reason why it hasn't been
upstreamed yet?

(add-before 'configure 'bootstrap
+             (lambda _
+               (system* "aclocal")
+               (system* "libtoolize" "--automake" "--copy")
+               (system* "autoconf")
+               (system* "autoheader")
+               (system* "automake" "--gnu" "--add-missing" "--copy")
+               #t))

Why not (add-before 'configure 'autoreconf
(lambda _
  (zero? (system* "autoreconf" "-vfi"))

I prefer indenting like this as is done in most of the codebase:

+      (inputs
          `(("libusb" ,libusb)
+          ("libusb-compat" ,libusb-compat)
+          ("libftdi" ,libftdi)
+          ("hidapi" ,hidapi)))
+      (native-inputs
          `(("autoconf" ,autoconf)
+          ("libtool" ,libtool)
+          ("automake" ,automake)
+          ("pkg-config" ,pkg-config)))

It would also be nice if the inputs where ordered alphabetically.

Thanks for the patch, looking good!! You don't need to resubmit
(unless someone else has more objections :).

David