Re: [PATCH 2/4] gnu: Add r-bigmemory-sri.

[Ricardo Wurmus]

Roel Janssen <address@hidden> writes:

> * gnu/packages/statistics.scm (r-bigmemory-sri): New variable.
> ---
>  gnu/packages/statistics.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 9e2d4a9..a50e792 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -2810,6 +2810,25 @@ via mutexes and may eventually support interprocess 
> communication and
>  message passing.")
>      (license (list license:lgpl2.1 license:asl2.0))))
>  
> +(define-public r-bigmemory-sri
> +  (package
> +    (name "r-bigmemory-sri")
> +    (version "0.1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "bigmemory.sri" version))

I think this should have a property to record the upstream name to help
the updater.

> +       (sha256
> +        (base32
> +         "0mg14ilwdkd64q2ri9jdwnk7mp55dqim7xfifrs65sdsv1934h2m"))))
> +    (build-system r-build-system)
> +    (home-page
> +     "http://cran.r-project.org/web/packages/bigmemory.sri";)

Please pull them onto one line.

> +    (synopsis "A shared resource interface for the bigmemory
> package")

Don’t start with “A”.

> +    (description "This package provides a shared resource interface for the
> +bigmemory and synchronicity packages.")
> +    (license (list license:lgpl3 license:asl2.0))))

What does this list mean?
Also: is this LGPL3+ or LGPL3 only?

~~ Ricardo