guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/68] gnu: bluez-qt: Update to 5.27.0.


From: Leo Famulari
Subject: Re: [PATCH 07/68] gnu: bluez-qt: Update to 5.27.0.
Date: Sat, 29 Oct 2016 16:33:37 -0400
User-agent: Mutt/1.7.1 (2016-10-04)

On Sat, Oct 29, 2016 at 08:04:18PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks.scm (bluez-qt): Update to 5.27.0 and
>   fix indentation.

In general, when making many changes that have no effect (for example,
several dozen indentation fixes), I think they should be done
separately.

A purely cosmetic commit can be easily audited by rebuilding the package
after the commit. If only indentation was changed, no rebuild will be
required.

By combining the "real" and cosmetic changes, the burden on reviewers is
increased significantly. Now, we have to manually compare the
re-indented code to verify that nothing changed.

Something to keep in mind in the future...



reply via email to

[Prev in Thread] Current Thread [Next in Thread]