[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mps-youtube, revision 3
From: |
Marius Bakke |
Subject: |
Re: [PATCH] mps-youtube, revision 3 |
Date: |
Sat, 05 Nov 2016 12:33:13 +0000 |
User-agent: |
Notmuch/0.23.1 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) |
Hartmut Goebel <address@hidden> writes:
> Am 04.11.2016 um 20:23 schrieb ng0:
>> [PATCH 1/2] gnu: Add python-pafy.
>>
>> - made youtube-dl propagated-input as suggested by harmut
>>
>> [PATCH 2/2] gnu: Add mps-youtube.
>>
>> - no changes
>>
>
> Both LGTM.
>
> Adding the comment about youtube_dl was a good idea :-)
Both of these packages have 'or later' in the source license header.
Also mps-youtube does not need mpv or ffmpeg in inputs, since they are
optional runtime dependencies. Additionally home-page should be https.
Other than that this works great, neat program!
I pushed the patches with these changes, and a minor edit to the
mps-youtube description to make it clear that mplayer or mpv is
required.
signature.asc
Description: PGP signature
- [PATCH 2/2] gnu: Add mps-youtube., (continued)
- [PATCH 2/2] gnu: Add mps-youtube., ng0, 2016/11/02
- [PATCH 1/2] gnu: Add python-pafy., ng0, 2016/11/02
- Re: [PATCH 1/2] gnu: Add python-pafy., Hartmut Goebel, 2016/11/02
- Re: [PATCH 1/2] gnu: Add python-pafy., ng0, 2016/11/04
- Re: [PATCH 1/2] gnu: Add python-pafy., Hartmut Goebel, 2016/11/04
- Re: [PATCH 1/2] gnu: Add python-pafy., ng0, 2016/11/04
- [PATCH] mps-youtube, revision 3, ng0, 2016/11/04
- [PATCH 1/2] gnu: Add python-pafy., ng0, 2016/11/04
- [PATCH 2/2] gnu: Add mps-youtube., ng0, 2016/11/04
- Re: [PATCH] mps-youtube, revision 3, Hartmut Goebel, 2016/11/04
- Re: [PATCH] mps-youtube, revision 3,
Marius Bakke <=
- Re: [PATCH] mps-youtube, revision 3, ng0, 2016/11/05
Re: [PATCH] mps-youtube, Marius Bakke, 2016/11/02