guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v5 0/1] gnu: Add plantuml.


From: Theodoros Foradis
Subject: [PATCH v5 0/1] gnu: Add plantuml.
Date: Mon, 7 Nov 2016 15:21:57 +0200

Roel Janssen writes:

> Theodoros Foradis writes:
>
>> Roel Janssen writes:
>>
>>> I tried running plantuml with the following snippet:
>>> @startuml
>>> A <..> B
>>> @enduml
>>>
>>> And it crashes because it attempts to run "/usr/bin/dot".
>>>
>>> With the following snippet, we replace this "/usr/bin/dot" dependency
>>> with the proper one from the graphviz input:
>>>
>>> (add-before 'build 'patch-usr-bin-dot
>>>   (lambda* (#:key inputs #:allow-other-keys)
>>>     (let ((dot (string-append (assoc-ref inputs "graphviz")
>>>                                "/bin/dot")))
>>>       (substitute*
>>>         "src/net/sourceforge/plantuml/cucadiagram/dot/GraphvizLinux.java"
>>>         (("/usr/bin/dot") dot)))))
>>>
>>
>> Nice catch! Thanks for testing that.
>>
>>> Could you add this snippet?
>>>
>>> Other than this, it works fine for me.
>>>
>>> Kind regards,
>>> Roel Janssen
>>
>> Let me know if I need to post an updated patch.
>
> Please do.  Have all comments been incorporated into this version of the
> patch?  If so, I guess we can push the version that includes my snippet,
> unless anyone still has any comments.
>

I have done all the changes suggested in the comments. I guess the
package is ready, if there are not any more. I have added your snippet
in this revised patch and lint finds no errors.

> Thanks!
>
> Kind regards,
> Roel Janssen

Regards,
-- 
Theodoros Foradis



reply via email to

[Prev in Thread] Current Thread [Next in Thread]