[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Explicitly pass grub to install, install-grub*, install-grub
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH] Explicitly pass grub to install, install-grub*, install-grub, initialize-hard-disk and qemu-image. |
|
Date: |
Thu, 10 Nov 2016 18:09:40 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hello!
Marius Bakke <address@hidden> skribis:
> Thanks for this patch! I have verified that it works both for `guix
> system vm-image` and on my grub-efi system.
>
> Do you think this eliminates the need for the "setenv PATH" trick in
> guix/scripts/system.scm:648? For the record, I tested the patch with
> that section removed as well, making sure there was no grub-install in
> my PATH.
I prefer that setting PATH to point to the right GRUB, rather than
having to carry the directory name of GRUB in 10 different places.
This is the approach taken in several places, such as (gnu system vm):
we set PATH, and then we can happily call functions that in turn expect
commands in $PATH.
Danny, what led you to this patch? :-)
Thanks,
Ludo’.