guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: Don't check file-systems in container tests.


From: Andy Patterson
Subject: Re: [PATCH] tests: Don't check file-systems in container tests.
Date: Sun, 13 Nov 2016 10:51:27 -0500

On Sun, 13 Nov 2016 13:05:43 +0100
address@hidden (Ludovic Courtès) wrote:

> Hi,
> 
> Andy Patterson <address@hidden> skribis:
> 
> > The containers test was hanging for me, and this patch fixed the
> > problem.  
> 
> [...]
> 
> > From 945ad44acf489b7f3a398d4ab739ec2b48477502 Mon Sep 17 00:00:00
> > 2001 From: Andy Patterson <address@hidden>
> > Date: Sat, 12 Nov 2016 22:10:01 -0500
> > Subject: [PATCH] tests: Don't check file-systems in container tests.
> >
> > * tests/containers.scm ("call-with-container, mnt namespace"): Don't
> > check file-system in 'call-with-container' call.
> > * tests/containers.scm
> > ("call-with-container, mnt namespace, wrong bindmount"): Likewise.
> > ---
> >  tests/containers.scm | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/containers.scm b/tests/containers.scm
> > index ccd122a..745b56b 100644
> > --- a/tests/containers.scm
> > +++ b/tests/containers.scm
> > @@ -84,7 +84,8 @@
> >     (call-with-container (list (file-system
> >                                  (device "none")
> >                                  (mount-point "/testing")
> > -                                (type "tmpfs")))
> > +                                (type "tmpfs")
> > +                                (check? #f)))  
> 
> Do you know exactly how/why it was hanging?  I imagine
> ‘mount-file-system’ would try to invoke fsck.tmpfs, which doesn’t
> exist, thus we get a REPL, which hangs forever.
> 

I did get a REPL (in the log file), so you're probably right.

> I guess the real question is why I didn’t experience it, hmm…
> 

Not sure, but I first noticed the problem when guix-devel was building
during a system reconfigure. That might be easier to reproduce.

> Thanks,
> Ludo’.

Thanks.

--
Andy




reply via email to

[Prev in Thread] Current Thread [Next in Thread]