Re: [PATCH 1/7] gnu: Add KDE frameworkintegration.

[Marius Bakke]

Hartmut Goebel <address@hidden> writes:

> * gnu/packages/kde-frameworks.scm (frameworkintegration): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 51 
> +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 9df37ac..0e6b8fb 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -2798,3 +2798,54 @@ setUrl, setUserAgent and call.")
>  script engines.")
>      ;; dual licensed
>      (license (list license:gpl2+ license:lgpl2.1+))))
> +
> +;; Tier 4
> +;;
> +;; Tier 4 frameworks can be mostly ignored by application programmers; this
> +;; tier consists of plugins acting behind the scenes to provide additional
> +;; functionality or platform integration to existing frameworks (including
> +;; Qt).
> +
> +(define-public frameworkintegration
> +  (package
> +    (name "frameworkintegration")
> +    (version "5.27.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://kde/stable/frameworks/"
> +                    (version-major+minor version) "/"
> +                    name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "0zpv7wj2006f039wr1gp5bc4md8yq9ig5g3v5mx46sdjip5423p1"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("kconfig" ,kconfig)
> +       ("kconfigwidgets" ,kconfigwidgets)
> +       ("kcoreaddons" ,kcoreaddons)
> +       ("kiconthemes" ,kiconthemes)
> +       ("kitemviews" ,kitemviews)
> +       ("knotificantions" ,knotifications)
> +       ("kwidgetsaddons" ,kwidgetsaddons)
> +       ("qtbase" ,qtbase)
> +       ("qtx11extras" ,qtx11extras)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'check-setup
> +           (lambda _
> +             (setenv "HOME" (getcwd))
> +             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
> +             (setenv "QT_QPA_PLATFORM" "offscreen")

Could you add a comment explaining what this variable does?

> +             #t)))))
> +    (home-page "https://community.kde.org/Frameworks";)
> +    (synopsis "KDE Frameworks 5 workspace and cross-framework integration 
> plugins")
> +    (description "Framework Integration is a set of plugins responsible for
> +better integration of Qt applications when running on a KDE Plasma
> +workspace.")
> +    ;; triple licensed
> +    (license (list license:gpl2+ license:lgpl2.0 license:lgpl2.0+))))

Please clarify. Is it all of them, or either? Or is it mostly gpl2+, but
some files are covered by the other two?

Otherwise LGTM!

signature.asc
Description: PGP signature