Re: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is followed by install-file <file> <dir>.

[Petter]

Hi,

Leo: Aha, yes you are right. I copy+pasted, and didn't realize those 
[source]
bits referred to fields in a recipe... Now I do, thanks! :)

Sure, I bring to you, two patches this time. One for master, and one for
core-updates. Not sure how to name the patch files properly, so I just 
put
branch name at the end.

Ludo: I like nitpicking ;)

I checked the packages with `guix refresh -l`, output below:

No dependents other than itself: eigensoft-6.1.2-1.b14d1e202
No dependents other than itself: snap-aligner-1.0beta.18
No dependents other than itself: pardre-1.1.5
No dependents other than itself: piranha-1.2.1-1.0466d364b
No dependents other than itself: hypre-2.11.0
No dependents other than itself: mpc123-0.2.4
No dependents other than itself: tuxguitar-1.3.2
No dependents other than itself: impressive-0.11.1

$ guix refresh -l address@hidden
  A single dependent package: bamm-1.7.3

$ guix refresh -l address@hidden
  Building the following 2 packages would ensure 5 dependent packages 
are
  rebuilt: virt-manager-1.4.0 python-libvirt-2.0.0



Let me know if there are any more issues.


Best,
Petter

On 2016-11-20 18:05, Leo Famulari wrote:
> On Sun, Nov 20, 2016 at 04:28:29PM +0100, Petter wrote:
> > From 595d438789c7c9a293ae7fac500ace7422073624 Mon Sep 17 00:00:00 2001
> > From: Petter <address@hidden>
> > Date: Sun, 20 Nov 2016 13:39:13 +0100
> > Subject: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is 
> > followed by
> >  install-file <file> <dir>.
> >
> > * gnu/packages/bioinformatics.scm (bwa)[source]: Remove redundant 
> > mkdir-p.
> > * gnu/packages/bioinformatics.scm (eigensoft)[source]: Likewise.
> > * gnu/packages/bioinformatics.scm (snap-aligner)[source]: Likewise.
> > * gnu/packages/bioinformatics.scm (pardre)[source]: Likewise.
> > * gnu/packages/bioinformatics.scm (piranha)[source]: Likewise.
> > * gnu/packages/maths.scm (hypre)[source]: Likewise.
> > * gnu/packages/mp3.scm (mpc123)[source]: Likewise.
> > * gnu/packages/music.scm (tuxguitar)[source]: Likewise.
> > * gnu/packages/pdf.scm (impressive)[source]: Likewise.
> > * gnu/packages/qemu.scm (qemu)[source]: Likewise.
> > * gnu/packages/tls.scm (openssl)[source]: Likewise.
>
> Thanks! A few requests...
>
> First, I think that most, if not all, of these changes are not in the
> [source] field of the changed package definitions. I bet that they are
> all in the [arguments] field. Can you send a revised patch with an
> updated commit message?
>
> Second, we can't change the OpenSSL package on the master branch,
> because many things depend on it:
>
> $ guix refresh -l address@hidden
> Building the following 1090 packages would ensure 2981 dependent
> packages are rebuilt
> [...]
>
> We do non-security related changes to that sort of "core" package on 
> the
> core-updates branch, which is merged into master every couple months.
> Otherwise, we'd be rebuilding everything constantly, and users would be
> unhappy.
>
> So, will you submit a separate patch for the OpenSSL change? Make sure
> it applies cleanly to the core-updates branch. You don't need to try
> building this; it will take forever, as you noticed.

0001-gnu-Remove-redundancy-where-mkdir-p-dir-is-[master].patch
Description: Text Data

0001-gnu-Remove-redundancy-where-mkdir-p-d[core-updates].patch
Description: Text Data