Re: [PATCH] gc: Add option --keep-going.

[Ludovic Courtès]

Hartmut Goebel <address@hidden> skribis:

> Am 18.11.2016 um 05:49 schrieb Eric Bavier:
>>> > +                printMsg(lvlError, format("cannot delete path `%1%' 
>>> > since it is still alive") % *i);
>>                                ^
>> Is error formatting appropriate, or is there a warning level we can use?
>>
>
> I agree that these are warnings and no errors. There is not "lvlWarn",
> thoug, just "lvlInfo". So I took this value from a few lines below which
> say:
>
>         if (state.shouldDelete)
>             printMsg(lvlError, format("deleting garbage..."));
>         else
>             printMsg(lvlError, format("determining live/dead paths..."));
>
> So, what do you think?

I think you’re right: lvlError is OK here, there’s a precedent.

Thanks,
Ludo’.