[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add Kerberos client service.
From: |
John Darrington |
Subject: |
Re: [PATCH] gnu: Add Kerberos client service. |
Date: |
Wed, 30 Nov 2016 14:44:18 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Nov 30, 2016 at 02:09:17PM +0100, Ludovic Court??s wrote:
John Darrington <address@hidden> skribis:
> * doc/guix.texi (Kerberos Services)[Krb5 Service]: New subsubheading.
> * gnu/services/kerberos.scm (krb5-service-type): New variable.
Please mention the configuration.scm changes.
ok.
> address@hidden Krb5 Service
> +
> +The krb5 service provides the configuration for Kerberos clients, using
> +the MIT implementation of the Kerberos protocol address@hidden
Please take into account my previous suggestions:
https://lists.gnu.org/archive/html/guix-devel/2016-11/msg00922.html
ok
Shouldn???t it be a single comma in @uref?
I don't think so. The Texinfo manual suggests, that in this case, the second
arg
should be empty.
> (define (validate-configuration config fields)
> (for-each (lambda (field)
> (let ((val ((configuration-field-getter field) config)))
> - (unless ((configuration-field-predicate field) val)
> + (unless (or (not val) ((configuration-field-predicate
field) val))
> (configuration-field-error
> (configuration-field-name field) val))))
Here you???re assuming that when VAL is #f, it???s necessary invalid, an
assumption that???s questionable and wasn???t made until now.
No. I'm assuming the exact opposite, namely, that #f is a *valid* value.
Can you instead change your own field predicate to do that?
I could do that, but then I'd be defining a lot of them which are substantially
identical to existing ones - and below, you say that you don't want me to
duplicate code ...
> +
> +(define (serialize-non-negative-integer field-name val)
> + (if val
> + (serialize-field* field-name val)))
> +
> +(define (serialize-integer field-name val)
> + (if val
> + (serialize-field* field-name val))
No ???else??? here? Looks like a bug.
No. The idea is, that if fields are #f then they output absolutely nothing.
How much of this is copied from configuration.scm? I don???t want
duplicated code here.
Much of it was copied, but modified where appropriate. None is identical
I don't think.
J'
--
Avoid eavesdropping. Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature
- [PATCH] gnu: Add kerberos service., John Darrington, 2016/11/09
- Re: [PATCH] gnu: Add kerberos service., John Darrington, 2016/11/18
- Re: [PATCH] gnu: Add kerberos service., Ludovic Courtès, 2016/11/18
- Re: [PATCH] gnu: Add kerberos service., John Darrington, 2016/11/19
- Re: [PATCH] gnu: Add kerberos service., Ludovic Courtès, 2016/11/21
- [PATCH] gnu: Add Kerberos client service., John Darrington, 2016/11/22
- Re: [PATCH] gnu: Add Kerberos client service., Ludovic Courtès, 2016/11/23
- [PATCH] gnu: Add Kerberos client service., John Darrington, 2016/11/29
- [PATCH] gnu: Add Kerberos client service., John Darrington, 2016/11/29
- Re: [PATCH] gnu: Add Kerberos client service., Ludovic Courtès, 2016/11/30
- Re: [PATCH] gnu: Add Kerberos client service.,
John Darrington <=
- Re: [PATCH] gnu: Add Kerberos client service., Andy Wingo, 2016/11/30