Re: [PATCH 2/2] system: Add btrfs file system support.

[Ludovic Courtès]

David Craven <address@hidden> skribis:

> Then there is the label and uuid detection logic for every file-system
> that needs to be implemented. I'm wondering if it can be refactored, a
> quick late night and untested implementation for btrfs suggests that
> there is a lot of code repetition involved, I guess the same will be
> true for vfat. I'll have to check if there are any tests for this
> anywhere or write some before I mess with this "core piece" of guix.

This is covered by tests like “basic” and other lightweight tests: they
boot the system, so they get to exercise the file system label/UUID
lookup code (if the root partition is specified by a label/UUID at
least).

> Ludo: Is there any way we can speed up the installer system tests? :)

Most of the time is spent in building the latest Guix and running ‘guix
system init’.  I don’t think this can be sped up.

The QEMU images involved are copied around, and maybe that part can be
slightly optimized.  I did that in
130079ae27b47228516dc2934bcdecca5dbedf12.

Ludo’.