guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: python-pyqt: Fix build by explicitly setting the stubsd


From: Ricardo Wurmus
Subject: Re: [PATCH] gnu: python-pyqt: Fix build by explicitly setting the stubsdir.
Date: Sat, 03 Dec 2016 17:12:17 +0100
User-agent: mu4e 0.9.16; emacs 25.1.1

Hartmut Goebel <address@hidden> writes:

> Without this option the stub files are tried to be installed into
> the python package's site-package directory.
>
> * gnu/packages.qt.scm (python-pyqt, python2-pyqt)[arguments]: In phase
> 'configure' pass option --stubsdir.
> ---
>  gnu/packages/qt.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index b442356..92c6d4b 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -982,13 +982,15 @@ module provides support functions to the automatically 
> generated code.")
>                          "."))
>                      (lib (string-append out "/lib/python"
>                                          python-major+minor
> -                                        "/site-packages")))
> +                                        "/site-packages"))
> +                    (stubs (string-append lib "/PyQt5")))
>                 (zero? (system* "python" "configure.py"
>                                 "--confirm-license"
>                                 "--bindir" bin
>                                 "--destdir" lib
>                                 "--designer-plugindir" designer
>                                 "--qml-plugindir" qml
> +                               "--stubsdir" stubs  ; PEP 484 Type Hints stubs
>                                 "--sipdir" sip))))))))
>      (home-page "https://www.riverbankcomputing.com/software/pyqt/intro";)
>      (synopsis "Python bindings for Qt")

The patch looks okay to me, but I’d prefer to see your comment about why
this is needed inline above the option.  “PEP 484…” doesn’t tell me
anything, whereas your description in this email was very clear.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net




reply via email to

[Prev in Thread] Current Thread [Next in Thread]