guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] gnu: lvtk: Build UI library.


From: Marius Bakke
Subject: Re: [PATCH 1/2] gnu: lvtk: Build UI library.
Date: Sat, 03 Dec 2016 22:04:44 +0100
User-agent: Notmuch/0.23.3 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu)

Ricardo Wurmus <address@hidden> writes:

> * gnu/packages/audio.scm (lvtk)[inputs]: Add gtkmm-2.
> [arguments]: Pass "-std=c++11" flag.
> ---
>  gnu/packages/audio.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 5de0681..d7bdc01 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -1653,9 +1653,16 @@ software.")
>                       (setenv "LDFLAGS"
>                               (string-append
>                                "-L" (assoc-ref inputs "boost") "/lib "
> -                              "-lboost_system")))))))
> +                              "-lboost_system"))
> +                     ;; Needed for gtkmm
> +                     (substitute* '("src/wscript_build"
> +                                    "examples/wscript_build")
> +                       (("cxxflags.*= \\[" line)
> +                        (string-append line "\"-std=c++11\", ")))
> +                     #t)))))

Is it not possible to pass this through #:make-flags? If not this LGTM,
but would be nice with a comment about why make-flags won't work.

>      (inputs
>       `(("boost" ,boost)
> +       ("gtkmm" ,gtkmm-2)
>         ("lv2" ,lv2)))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)))
> -- 
> 2.10.2

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]