[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: file-system-shepherd-service: Use mount-file-system.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: file-system-shepherd-service: Use mount-file-system. |
Date: |
Sun, 04 Dec 2016 22:12:00 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
John Darrington <address@hidden> skribis:
> On Wed, Nov 30, 2016 at 01:51:23PM +0100, Ludovic Court??s wrote:
> John Darrington <address@hidden> skribis:
>
> > * gnu/services/base.scm (file-system-shepherd-service): Use
> mount-file-system
> > instead of manually mounting the file system.
>
> [...]
>
> > + #$(if create?
> > + #~(mkdir-p #$target)
> > + #~#t)
>
> #~#t is equivalent to #t.
>
> > + (mount-file-system
> > + `(#$device #$title #$target #$type #$flags
> #$options
> > + #$check?) #:root "/")
> > #t))
>
> #t must be align with the parent of ???(mount-file-system???.
>
> If you confirmed that at least ???make check-system TESTS=basic???
> passes,
> fine with me.
>
>
> Perhaps somebody who already has a copy of qemu in their store could check
> that
> for me?
hydra.gnu.org has a copy. :-)
Anyway, thanks for pushing this!
Ludo’.