Re: [PATCH 2/2] import: cpan: Add CPAN updater.

[Ludovic Courtès]

Eric Bavier <address@hidden> skribis:

> * guix/import/cpan.scm (module->dist-name): Fetch the field of interest.
> (cpan-fetch): Accept release name rather than module name.
> (fix-source-url): Rename to ...
> (cpan-source-url): ... this.  Take metadata as parameter.
> (cpan-module->sexp): Move local core-module? procedure to ...
> (core-module?): ... here.
> (package->upstream-name, cpan-version, cpan-package?, latest-release):
> New procedures.
> (%cpan-updater): New variable.
> * guix/scripts/refresh.scm (%updaters): Add %cpan-updater.

[...]

> +(define core-module?
> +  (let ((perl-version (package-version perl))
> +        (rx (make-regexp
> +             (string-append "released with perl v?([0-9\\.]*)"
> +                            "(.*and removed from v?([0-9\\.]*))?"))))
> +    (lambda (name)

For clarity you could make this change (moving ‘core-module?’ to the top
level) in a separate patch maybe.

Otherwise that LGTM, though I haven’t actually tested it.

Thank you!

Ludo’.