[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] import: cpan: Add CPAN updater.
|
From: |
Eric Bavier |
|
Subject: |
Re: [PATCH 2/2] import: cpan: Add CPAN updater. |
|
Date: |
Wed, 7 Dec 2016 23:45:20 -0600 |
On Wed, 07 Dec 2016 12:02:35 +0100
address@hidden (Ludovic Courtès) wrote:
> Eric Bavier <address@hidden> skribis:
>
> > * guix/import/cpan.scm (module->dist-name): Fetch the field of interest.
> > (cpan-fetch): Accept release name rather than module name.
> > (fix-source-url): Rename to ...
> > (cpan-source-url): ... this. Take metadata as parameter.
> > (cpan-module->sexp): Move local core-module? procedure to ...
> > (core-module?): ... here.
> > (package->upstream-name, cpan-version, cpan-package?, latest-release):
> > New procedures.
> > (%cpan-updater): New variable.
> > * guix/scripts/refresh.scm (%updaters): Add %cpan-updater.
>
> [...]
>
> > +(define core-module?
> > + (let ((perl-version (package-version perl))
> > + (rx (make-regexp
> > + (string-append "released with perl v?([0-9\\.]*)"
> > + "(.*and removed from v?([0-9\\.]*))?"))))
> > + (lambda (name)
>
> For clarity you could make this change (moving ‘core-module?’ to the top
> level) in a separate patch maybe.
Good idea.
> Otherwise that LGTM, though I haven’t actually tested it.
Great. For me it detects over 100 package upgrades :)
`~Eric