Re: 01/01: gnu: python-pyopenssl: Disable tests.

[Marius Bakke]

Leo Famulari <address@hidden> writes:

> On Fri, Dec 16, 2016 at 02:21:47PM +0100, Marius Bakke wrote:
>> Leo Famulari <address@hidden> writes:
>> > On Wed, Dec 14, 2016 at 05:38:04PM +0000, Marius Bakke wrote:
>> >> +    (arguments
>> >> +     ;; FIXME: Some tests fail with "NameError: name 'long' is not 
>> >> defined".
>> >> +     '(#:tests? #f))
>> >
>> > Do you think this indicates a real problem? Or is the issue limited to
>> > the tests?
>> 
>> I dug a bit further into this, and the problem is likely that PYTHONPATH
>> is incomplete at test time. Moving 'check after 'install and adding a
>> proper PYTHONPATH seems to work, but now I ran into a test needing
>> network access.
>> 
>> https://github.com/pyca/pyopenssl/blob/16.2.0/tests/test_ssl.py#L1186
>> 
>> I'll prepare a patch to remove that test entirely, unless someone knows
>> a clever way to check for network access and conditionally skip it
>> (which I'm sure upstream would be happy to accept).
>
> I think it's fine to simply skip or remove that test.

Way ahead of you: 7c6bf660d8a455090f4c140c5b2849f1b58f2fe3 :-)

signature.asc
Description: PGP signature