Re: [PATCH] gnu: Add tipp10 touch typing tutor.

[Ludovic Courtès]

Hi!

Hartmut Goebel <address@hidden> skribis:

> * gnu/packages/education.scm (touch10): New variable.
> * gnu/packages/patches/tipp10-FixCompiling.patch,
>   gnu/packages/patches/tipp10-RemoveLicenseCode.patch: New files.
> * gnu/local.mk (dist_patch_DATA): Register them.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://debian/pool/main/"
> +                                  "t/tipp10/tipp10_2.1.0.orig.tar.gz"))

Is there really no upstream for this program?  tipp10.com seems to be
live, no?

> +              (patches (search-patches "tipp10-FixCompiling.patch"
> +                                       "tipp10-RemoveLicenseCode.patch"))))

Please use lowercase and hyphens for file names.  :-)

> +    (home-page "https://www.tipp10.com/";)
> +    (synopsis "Touch typing tutor")
> +    (description " TIPP10 is a free touch typing tutor for Windows, Mac OS 
> and
                     ^
Extra space.

Please don’t mention supported operating systems; what matters is that
it works on GNU.

> +Linux.  The ingenious thing about the software is its intelligence feature.

“Intelligence feature” sounds vague; could it be rephrased in more
precise terms?

> +Note: To change the language settings choose Datei (File) →
> +Grundeinstellungen (Generell Settings) → Sprache (Language) and change from
> +Deutsch to English. The you have restart the program to have the change take
> +effect.")

This information doesn’t belong here.

Does Debian have patches to make this program honor the current locale?
That would be the best option.

> +    (license license:gpl2)))

Version 2 only?

> +--- a/tipp10.desktop
> ++++ b/tipp10.desktop
> +@@ -1,10 +1,10 @@
> + [Desktop Entry]
> +-Encoding=UTF-8
> + Name=TIPP10
> + Comment=Touch Typing Tutor
> + Comment[de]=10-Finger-Schreibtrainer
> +-Exec=tipp10
> ++Exec=/usr/bin/tipp10

This doesn’t look useful.

Could you send an updated version?

Thank you!

Ludo’.