guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Elpa importer improvements


From: Carlo Zancanaro
Subject: Re: [PATCH] Elpa importer improvements
Date: Tue, 27 Dec 2016 21:20:17 +1100
User-agent: mu4e 0.9.16; emacs 25.1.1

On Tue, Dec 27 2016, Alex Kost wrote
[...]

- (proc (http-fetch/cached (string->uri url)))) + (catch #t + (lambda () + (proc (http-fetch/cached (string->uri url)))) + (lambda (key . args) + (if error-thunk + (error-thunk) + (apply throw key args)))))

So here you fixed a regression introduced by commit 218622a73¹, thanks! I think it's better to call 'leave' on the last line as it was done originally.

Ah, so that's what it meant by "leave"! I misunderstood. I had interpreted it as "leave the error alone", so thought re-throwing was consistent with that. I've attached an updated patch to use the original "leave" line.

Attachment: 0001-import-elpa-Fix-call-with-downloaded-file.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]