Re: [PATCH] gnu: leptonica: Update to 1.73.

[Marius Bakke]

"Taylan Ulrich Bayırlı/Kammer" <address@hidden> writes:

> Marius Bakke <address@hidden> writes:
>
>> "Taylan Ulrich Bayırlı/Kammer" <address@hidden> writes:
>>
>>> You know what, Leptonica 1.74.0 has been released yesterday, so here's a
>>> new patch. :-D
>>>
>>> But yes, the source snippet / patch for the .pc file isn't necessary
>>> anymore for reasons not really clear to me.  (The two libs still need to
>>> be propagated and Tesseract has to link against them; maybe Tesseract
>>> special-handles this and other dependents of Leptonica could still
>>> benefit from a patched .pc file, but so far we don't have any other
>>> dependents of Leptonica...)
>>>
>>> The config.h hack probably wasn't necessary anymore since 1.72; I had
>>> introduced it with 1.71 where the issue existed and it didn't get
>>> removed upon the 1.72 update.
>>>
>>> And all tests pass, without having to disable parallel tests either.
>>>
>>> The 1.74.0 tag on GitHub corresponds to a state in which ./configure
>>> doesn't exist; the autobuild script needs to be run.
>>>
>>> So here's the new patch.
>>
>> Thanks for the clarification and update, pushed!
>>
>> I completely forgot to mention the origin and argument changes in the
>> commit message as we usually do. Hopefully the next update can include
>> that too ;-)
>
> Thanks. :-)
>
> FYI I have push access so in the future you can just tell me to push it.

Oh, thanks for letting me know :-)

> I guess I can be more strict with the commit lines.  Usually I assume
> that some changes to the rest of the recipe are implied in a version
> update...

I think it is useful to mention such changes in the commit message, so
that one can clearly see in the git log which commit introduced e.g. a
new phase, or new source URL, instead of having to dig through the full
diffs (or blame) to find it.

signature.asc
Description: PGP signature